-
Notifications
You must be signed in to change notification settings - Fork 3.8k
tools/wpt/ tests fail on Windows because Chrome Dev isn't installed #28745
Copy link
Copy link
Closed
Labels
Description
Happening on several PRs, include #28741 and #28652. The failing test doesn't have anything to do with these PRs.
Link to a typical error log: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=64723&view=logs&j=775b4849-c968-5044-becb-3d45fabe691a&t=b3b63ffd-da0b-51fb-c375-a27ecd9b6f5a
Snip of the failing test:
____________________________ test_run_failing_test ____________________________
@pytest.mark.slow
@pytest.mark.remote_network
def test_run_failing_test():
"""Failing tests should be reported with a non-zero exit status unless the
`--no-fail-on-unexpected` option has been specified."""
if is_port_8000_in_use():
pytest.skip("port 8000 already in use")
failing_test = "/infrastructure/expected-fail/failing-test.html"
assert os.path.isfile("../../%s" % failing_test)
with pytest.raises(SystemExit) as excinfo:
wpt.main(argv=["run", "--yes", "--no-pause", "--channel", "dev",
"chrome", failing_test])
assert excinfo.value.code != 0
with pytest.raises(SystemExit) as excinfo:
wpt.main(argv=["run", "--yes", "--no-pause", "--no-fail-on-unexpected",
"--channel", "dev", "chrome", failing_test])
> assert excinfo.value.code == 0
E assert 1 == 0
E + where 1 = SystemExit(1).code
E + where SystemExit(1) = <ExceptionInfo SystemExit tblen=2>.value
tests\test_wpt.py:201: AssertionError
Reactions are currently unavailable