Repository navigation
Commit 3127c3a
[WebCrypto] Fix supports() for exportKey and wrapKey
supports() is specified to accept "exportKey" as an operation, and to
return false for "wrapKey" when additionalAlgorithm does not support the
export key operation. Blink returned false for every "exportKey" query,
and returned true for "wrapKey" with an HKDF or PBKDF2
additionalAlgorithm even though wrapKey() rejects such keys with a
NotSupportedError:
https://wicg.github.io/webcrypto-modern-algos/#SubtleCrypto-method-supports
Map "exportKey" to kWebCryptoOperationExportKey and add the wrapKey
check, using the export key operation info added in
https://crrev.com/c/8312049. Add WPTs for both cases.
Fixed: 41264071
Change-Id: If0e60ecfc2c52ac7b2fcbbfdfbc2855c00524853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8471207
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Minseop Choi <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1706614}1 parent 3b5f16e commit 3127c3a
1 file changed
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
728 | 728 | | |
729 | 729 | | |
730 | 730 | | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
731 | 750 | | |
732 | 751 | | |
733 | 752 | | |
0 commit comments