Skip to content

Commit 1221018

Browse files
tkent-googleSkyBlack1225
tkent-google
authored and
SkyBlack1225
committed
LayoutMedia: Should not handle OOF boxes
After LayoutMediaNGContainer task, LayoutMedia could be a container of its OOF descendants, but NGReplacedLayoutAlgorithm has no ability to lay out OOF boxes. This CL fixes the issue by making LayoutMedia children OOF containers by forcing paint containment. Bug: 1425520 Change-Id: I19e10c9a94341cba376883bf544ef69ea413dca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349736 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1119211}
1 parent 3640f07 commit 1221018

2 files changed

Lines changed: 37 additions & 0 deletions

File tree

‎webvtt/rendering/cues-with-video/processing-model/evil/non-standard-pseudo-elements-ref.html‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<!DOCTYPE html>
2+
<html lang="en" class="reftest-wait">
3+
<style>
4+
video { width:560px; height:320px; }
5+
</style>
6+
<video>
7+
<source src="/media/white.webm" type="video/webm">
8+
<source src="/media/white.mp4" type="video/mp4">
9+
<track label="English subtitles" kind="subtitles" srclang="en" src="support/test.vtt" default>
10+
</video>
11+
<script>
12+
const v = document.querySelector('video');
13+
v.onseeked = () => { document.documentElement.classList.remove('reftest-wait'); };
14+
v.currentTime = 3;
15+
</script>
16+
</html>

‎webvtt/rendering/cues-with-video/processing-model/evil/non-standard-pseudo-elements.html‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<!DOCTYPE html>
2+
<html lang="en" class="reftest-wait">
3+
<title>position:fixed on non-standard ::-webkit-media-text-track-display should not affect</title>
4+
<link rel="match" href="non-standard-pseudo-elements-ref.html">
5+
<style>
6+
video { width:560px; height:320px; }
7+
video::-webkit-media-text-track-display {
8+
position: fixed !important;
9+
}
10+
</style>
11+
<video>
12+
<source src="/media/white.webm" type="video/webm">
13+
<source src="/media/white.mp4" type="video/mp4">
14+
<track label="English subtitles" kind="subtitles" srclang="en" src="support/test.vtt" default>
15+
</video>
16+
<script>
17+
const v = document.querySelector('video');
18+
v.onseeked = () => { document.documentElement.classList.remove('reftest-wait'); };
19+
v.currentTime = 3;
20+
</script>
21+
</html>

0 commit comments

Comments
 (0)