Skip to content

RFC 69: Switch web-platform-tests to Python 3#69

Merged
jgraham merged 2 commits intomasterfrom
python3
Nov 20, 2020
Merged

RFC 69: Switch web-platform-tests to Python 3#69
jgraham merged 2 commits intomasterfrom
python3

Conversation

@jgraham
Copy link
Contributor

@jgraham jgraham commented Nov 12, 2020

No description provided.

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 12, 2020

I'm wondering if the timeline isn't too tight. I'd assume we lost at least the last two weeks of the year to various people's holidays, so that leaves about 5 weeks at best from today to get everything finished on our side and on the vendors's side. Moving the timeline by two weeks or a month might mean people don't have to rush as much. I don't know how urgently people need to move this along, though, so happy to be overruled on this if it seems feasible to the people who are going to do the work.

@jgraham
Copy link
Contributor Author

jgraham commented Nov 12, 2020

I want to switch Gecko over asap after upstream, but not before. I also don't want Gecko on 2.7 next year. So from my point of view doing the GitHub change on the last week of November and then doing the Gecko change the first week of December seems fine, although there could be breakage that doesn't happen upstream (I think I checked most things but not everything). So from my point of view this timetable is tight but doable. If we were going to slip dates I'd like it to be extending the vendor "deadline" to mid Jan or 1st Feb. and moving the end of Py 2 support to match. Obviously the longer the overall transition period is the more chance we get get cross-version breakage. So if others have concerns we can make that kind of change, but I think this timetable can work for gecko.

@stephenmcgruer
Copy link
Contributor

Similarly I am looking to switch Chromium's use of WPT to Python 3 in early December.

rfcs/py_3.md Outdated

## Details

1. **November / December 2020** XXX add actual date - Python 3 becomes default on GitHub CI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the 'XXX add actual date' be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a guess, first attempt at this will likely happen the week of the 23rd. The handlers change RFC can be landed on the 17th, but that's the week of BlinkOn for us so I don't want to do the Python 3 switchover at the same time (and I'd like to give the handlers time to bake as well).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the document to list that date. I think if we miss the week of the 23rd for whatever reason we should consider pushing the other dates back too.

@stephenmcgruer stephenmcgruer changed the title Add an RFC for the overall Py3 transition RFC 69: Switch web-platform-tests to Python 3 Nov 12, 2020
@jgraham
Copy link
Contributor Author

jgraham commented Nov 20, 2020

This has now been >1 week without additional objects, so I'm going to merge it.

@jgraham jgraham merged commit bb7951c into master Nov 20, 2020
@jgraham jgraham deleted the python3 branch November 20, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants