-
Notifications
You must be signed in to change notification settings - Fork 83
Tentative testdriver methods #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+31
−0
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7cfbf57
Tentative testdriver methods
jcsteh bbb248e
Add additional risks per review.
jcsteh eaf2912
Cross-reference documentation on how to mark a test tentative.
jcsteh 58e5694
Clarify that this is about WebDriver endpoints not defined in any spe…
jcsteh 93d24b8
Apply suggestions from code review
zcorpan 03ef518
Apply suggestion
zcorpan 96cba2c
Update rfcs/tentative_testdriver_methods.md
zcorpan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # RFC 226: Tentative testdriver methods | ||
|
|
||
| ## Summary | ||
| Allow tentative methods to be added to testdriver.js which use WebDriver endpoints not yet defined in a specification. | ||
| This should only be allowed where there is consensus between multiple browser vendors and where there is clear progress towards a specification. | ||
|
|
||
| ## Background | ||
| As part of the [Interop 2025 Accessibility Investigation Area](https://github.com/web-platform-tests/interop-accessibility/issues/148), the intention is to extend browsers and WPT to allow additional accessibility properties to be tested by web platform tests. | ||
| However, there are open questions regarding the shape of the API for exposing these properties, what properties should be exposed, how the tests should be written, etc. | ||
| While the end goal is to extend the WebDriver specification with the required new endpoints, these open questions need to be answered before this is feasible. | ||
| To answer these questions, it would be helpful if browser vendors could collaborate on a tentative but working implementation. | ||
|
|
||
| ## Details | ||
| 1. There must be publicly documented (e.g. as part of an Interop Investigation Area) consensus between at least two browser vendors and intent to work towards a specification. | ||
zcorpan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 2. Any tests directly or indirectly calling tentative testdriver methods must be [marked tentative](https://web-platform-tests.org/writing-tests/file-names.html#:~:text=.tentative,-:%20). | ||
zcorpan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 3. These testdriver methods should assert that the test is tentative (URL path includes `.tentative' or '/tentative/'). | ||
|
|
||
| ## Alternatives considered | ||
| 1. Avoid any changes to the WPT repository until the specification is finalised. | ||
| This makes it very difficult for browser vendors to collaborate and to learn about problems that are much easier to discover and understand "in practice". | ||
| In contrast, if the specification were developed without a working implementation, there is a much higher risk of fundamental design problems in the specification which are much harder to fix later. | ||
zcorpan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 2. Develop the implementation as vendor specific tests with methods in testdriver-vendor.js. | ||
| While this does allow a single vendor to iterate on a working implementation, it is still very difficult for multiple browser vendors to collaborate on this. | ||
| At the very least, other vendors may wish to contribute tests which exercise the implementation to ensure it fits their needs before agreeing to a final specification. | ||
|
|
||
| ## Risks | ||
jcsteh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 1. Methods could be added which never end up being specified, resulting in cruft and non-standardised functionality. | ||
| This is not a significant risk to the web at large because these methods only impact tests and the tests must be marked tentative, preventing them from being considered for Interop scoring, for example. | ||
| 2. The API could change significantly before it becomes finalized, with many tests depending on the tentative API. | ||
| This could mean that migrating the tests to the final API requires significant effort. | ||
| 3. Because of the lack of specification, other vendors interested in ensuring interoperability with the feature being tested might have to reverse engineer how the tentative API is intended to function. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.