Tentative testdriver methods#226
Conversation
gsnedders
left a comment
There was a problem hiding this comment.
Most of my comments below are really "let's make this more explicit", rather than any real objection.
And mostly a question for the Core Team, but I do wonder what standard we thing we're holding things to based on #127: is an explainer enough for a testdriver API, or do we want a spec? Because if an explainer is enough, I'd question how often we'd actually add tentative API, because we probably do want something defining what the behaviour of the endpoint is, even if only at a high-level.
rfcs/tentative_testdriver_methods.md
Outdated
| # RFC 226: Tentative testdriver methods | ||
|
|
||
| ## Summary | ||
| Allow tentative methods to be added to testdriver.js that are not yet included in the WebDriver or WebDriver BiDi specifications. |
There was a problem hiding this comment.
Ah. I had assumed that the existence of a WebDriver endpoint implied it needed to be in the WebDriver spec. So how is WebDriver endpoint defined, given that Gecko uses Marionette for WPT and no other vendors implement this WebDriver endpoint yet?
There was a problem hiding this comment.
For example, https://webbluetoothcg.github.io/web-bluetooth/#automated-testing defines a whole load of endpoints.
The policy is that it requires a spec for the endpoint, not that that spec be in any specific standard.
There was a problem hiding this comment.
Thanks. Now I better understand your original question regarding whether an explainer is sufficient. I agree that at least having an explainer makes sense, so if the consensus is that an explainer is acceptable, we probably don't need this RFC. RFC 127 just says "an existing WebDriver endpoint", which isn't explicit about a formal spec, though I guess that could be inferred. So perhaps we still need an RFC making it clear that an explainer is sufficient.
That said, one difference between a spec and an explainer is that an explainer is far more likely to change than a spec. So that might still be one reason to mark these methods as tentative: to indicate that the details are still being ironed out.
Ms2ger
left a comment
There was a problem hiding this comment.
I have no fundamental concerns with this, assuming we'd use this for experimentation, not things that stick around indefinitely.
…cification, not just the WebDriver specifications.
jcscottiii
left a comment
There was a problem hiding this comment.
We discussed this today during the RFC meeting. I'm still opposed to the wording in Detail 1. But the rest of the RFC looks fine. And in the absence of better alternatives for that one point, I will approve this.
|
@gsnedders Can you take another look at this? |
|
An alternative to having |
cookiecrook
left a comment
There was a problem hiding this comment.
r+ with the addition of the new assertion expectation in tentative methods.
I think it's okay to dismiss @gsnedders review since it's 5 months old, was self-described as not a "real objection", and I believe has fully addressed in the latest iteration. |
Rendered.
CC @zcorpan, @cookiecrook.