Rename private to local in address space overrides#135
Merged
Conversation
In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ Chromium has also renamed private to local in https://source.chromium.org/chromium/chromium/src/+/d5b320062c4982d2e215386e068826f8bc97c512 so the ip-address-overrides switch value needs to be updated too. This PR makes the corresponding changes in the RFC.
Ms2ger
approved these changes
Mar 13, 2023
Contributor
Author
|
Thanks for the approval. Can someone with write access merge this PR? |
Contributor
|
No, per the process we need at least a week to allow people to read the RFC and bring forward any concerns. |
Contributor
|
Although we don't usually do in-place edits of RFCs like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in
WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/
Chromium has also renamed private to local in
https://source.chromium.org/chromium/chromium/src/+/d5b320062c4982d2e215386e068826f8bc97c512 so the ip-address-overrides switch value needs to be updated too.
This PR makes the corresponding changes in the RFC.
cc @letitz