chore(vscode-extension): update default test file glob pattern #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default test file glob pattern in the VSCode extension to only match JavaScript and TypeScript test files, replacing the previous pattern that matched any extension (e.g., **/*.test.* → **/*.{test,spec}.[jt]s).
Key Changes:
- Updated default glob patterns to specifically target JS/TS files with extensions:
.js,.ts,.jsx,.tsx,.cjs,.mjs,.cts,.mts, and their JSX variants - Modified the
isTestFilePathfunction to use a regex pattern instead of simple string matching - Added test coverage to verify that non-JS/TS files (e.g.,
.txtfiles) are excluded from test discovery
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vscode/src/config.ts | Updated defaultConfig.testFileGlobPattern to use specific JS/TS file extension patterns |
| packages/vscode/package.json | Updated the configuration schema default values to match the new patterns |
| packages/vscode/src/extension.ts | Replaced simple string matching in isTestFilePath() with regex pattern matching |
| packages/vscode/tests/suite/config.test.ts | Added test assertions to verify default pattern behavior and exclusion of .txt files |
| packages/vscode/tests/fixtures/test/jsFile.spec.js.txt | Added negative test fixture to verify non-JS/TS files are excluded |
| packages/vscode/tests/fixtures/.vscode/settings.json | Removed empty settings file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
fi3ework
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update default test file glob pattern, only match javascript / typescript test files.
Related Links
Checklist