chore: no need to run files when run list filesOnly #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the npx rstest list --filesOnly command by skipping unnecessary test file execution and build operations when only file listing is requested. It also enhances documentation for the include configuration option with additional context and examples.
- Refactored
listTestsfunction to conditionally use lightweight file collection when--filesOnlyflag is set - Updated documentation to clarify that
includepatterns are resolved relative to the configured root directory - Added examples and explanations of default matching behavior and glob pattern usage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/core/listTests.ts | Extracted test collection logic into collectTests and created new collectTestFiles function that skips build/execution overhead when only listing files |
| website/docs/en/config/test/include.mdx | Enhanced documentation with path resolution details, CLI usage examples, and glob pattern guidance |
| website/docs/zh/config/test/include.mdx | Chinese translation of the enhanced documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
npx rstest list --filesOnlyincludeconfiguration documentRelated Links
Checklist