Skip to content

chore: exports some Rstest API types #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
9aoy merged 1 commit into from
Nov 10, 2025
Merged

chore: exports some Rstest API types #682

9aoy merged 1 commit into from
Nov 10, 2025

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Nov 10, 2025

Summary

Exports some Rstest API types.

import type { Describe, Expect, RstestUtilities } from '@rstest/core';

type Options = {
  describe: Describe;
  expect:  Expect;
  rstest:  RstestUtilities;
}

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 10, 2025 08:24
@netlify
Copy link

netlify bot commented Nov 10, 2025 •
edited
Loading

✅ Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 7d91834
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/6911a12d2fe24500087583cc
😎 Deploy Preview https://deploy-preview-682--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI reviewed Nov 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the type exports from the core package by adding several testing API types that were previously internal. The changes expose key testing interfaces to external consumers.

  • Adds type exports for core testing APIs (Assertion, Describe, Expect, Rstest, RstestUtilities)
  • Exports RstestCommand type for programmatic usage
  • Uses type aliases for clearer naming (DescribeAPI → Describe, RstestExpect → Expect)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/core/src/index.ts
Comment on lines +68 to 78
Assertion,
DescribeAPI as Describe,
ProjectConfig,
Reporter,
Rstest,
RstestCommand,
RstestExpect as Expect,
RstestUtilities,
TestFileInfo,
TestFileResult,
TestResult,
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The exported types are not in alphabetical order. Consider maintaining alphabetical ordering for consistency and easier maintenance. The list should be: Assertion, DescribeAPI as Describe, RstestExpect as Expect, ProjectConfig, Reporter, Rstest, RstestCommand, RstestUtilities, TestFileInfo, TestFileResult, TestResult.

Copilot uses AI. Check for mistakes.
@9aoy 9aoy merged commit e2b4afb into main Nov 10, 2025
23 checks passed
@9aoy 9aoy deleted the more-rstest-types branch November 10, 2025 08:57
@9aoy 9aoy mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@9aoy