fix(esm-output): __webpack_require__.C is not a function
#656
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the mock runtime code for webpack module handling by replacing manual property copying with a Proxy-based approach and cleaning up variable declarations. The key changes improve the maintainability and robustness of the webpack require wrapper.
- Replaced manual property copying with a Proxy to dynamically intercept property access and assignment on
__webpack_require__ - Removed redundant
undefinedinitializations forrequiredModulevariables across multiple mock functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| get(target, property) { | ||
| if (property in target) { | ||
| return target[property]; | ||
| } | ||
| return originalWebpackRequire[property]; | ||
| }, |
There was a problem hiding this comment.
The get trap should check for properties on the target function before falling back to originalWebpackRequire. However, if a property is explicitly set to undefined on the target, this check will still return undefined instead of checking the original. Consider using hasOwnProperty or Object.prototype.hasOwnProperty.call(target, property) for more precise property existence checking.
Summary
fix
__webpack_require__.Cis not a function when outputs is esm format.Related Links
Checklist