fix: type error when each template type is primitive #653
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a TypeScript type error that occurs when using the each template with primitive types. The fix adds a new overload signature to TestEachFn that handles arrays of primitive values, ensuring proper type inference when the array elements themselves are the test parameters rather than tuples.
Key Changes:
- Added a new function overload to
TestEachFninterface for handling primitive type arrays - Added test case to verify the fix works with primitive number arrays
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/types/api.ts | Adds new overload signature to support primitive type arrays in TestEachFn |
| e2e/test-api/each.test.ts | Adds test case demonstrating the fix with a primitive number array |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cases: readonly T[], | ||
| ): ( | ||
| description: string, | ||
| fn: (...args: T[]) => MaybePromise<void>, |
There was a problem hiding this comment.
The parameter type T[] creates an array of T instead of spreading T as individual parameters. For primitive types, this should be (arg: T) or use conditional types. With the current signature, when T is number, the function expects (...args: number[]) which means any number of number arguments, not a single number argument as intended.
| fn: (...args: T[]) => MaybePromise<void>, | |
| fn?: (param: T) => MaybePromise<void>, |
Summary
fix type error when each template type is primitive.
expect:
actual:
Related Links
Checklist