fix: name conflicts when the project is a special configuration #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a naming conflict issue that occurs when a project uses a specific configuration file path instead of a directory path. The fix ensures that the project name is derived from the directory containing the config file rather than the config file path itself.
Key Changes:
- Updated logic to correctly determine project names when config file paths are used
- Improved documentation clarity for the
projectsconfiguration option
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/cli/init.ts | Fixed project name resolution to use the directory path instead of config file path |
| website/docs/en/config/test/projects.mdx | Clarified comment about projects configuration |
| website/docs/zh/config/test/projects.mdx | Clarified comment about projects configuration (Chinese version) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix name conflicts when the project is a special configuration.
Related Links
Checklist