perf: use nosources-source-map
#650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes source map generation by switching from source-map to nosources-source-map, which reduces source map file size by excluding the sourcesContent field that is unused in rstest.
Key Changes:
- Updated default devtool configuration to use
nosources-source-mapinstead ofsource-map - Applied the same optimization to inline source maps in the inspect plugin
- Updated test snapshots to reflect the new devtool configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/dictionary.txt | Added 'nosources' to the dictionary for spell-checking |
| packages/core/tests/core/snapshots/rsbuild.test.ts.snap | Updated test snapshots to expect nosources-source-map devtool value |
| packages/core/src/core/plugins/inspect.ts | Changed inspect plugin to use inline-nosources-source-map |
| packages/core/src/core/plugins/basic.ts | Added logic to set default devtool to nosources-source-map when not inline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
nosources-source-mapinstead ofsource-mapto reduce source map size, since "sourcesContent" is unused in rstest.https://rspack.rs/config/devtool#:~:text=nosources%2Dsource%2Dmap
Related Links
Checklist