fix(mock): prevent mocked module overwrite by new loaded chunk modules #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug where mocked modules could be overwritten when loading new chunks that contain duplicate module definitions. Previously, when multiple bundled entry points existed, modules present in multiple chunks would be re-installed, overwriting any existing mocks. The solution modifies the chunk loading runtime to skip reinstalling modules that have already been mocked.
Key Changes:
- Modified chunk loading runtime to prevent reinstallation of already-mocked modules
- Removed
RemoveDuplicateModulesPluginconfiguration as it's no longer needed - Updated plugin names for better clarity
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/core/rsbuild.ts | Removed RemoveDuplicateModulesPlugin and its import |
| packages/core/src/core/plugins/moduleCacheControl.ts | Updated plugin names from generic "CustomPlugin" to descriptive names |
| packages/core/src/core/plugins/mockRuntime.ts | Added runtime module hook to modify chunk loading behavior and prevent mocked module overwrites |
| e2e/watch/index.test.ts | Updated test expectations to reflect simpler chunk behavior without duplicate module removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9aoy
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when there are multiple bundled entry points (such as
rstest.setup.tsandindex.test.ts), the project's module may exist inexports.modulesof each chunk, which can lead to the following problem:this PR modifies the internal logic of
installChunkto no longer forcibly overwrite modules that have already been mocked. and because the use ofRemoveDuplicateModulesPluginhas been removed, the overall chunk is now simpler, so the watch test has also been rolled back.Related Links
Checklist