-
-
Notifications
You must be signed in to change notification settings - Fork 14
chore: update log display #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the reporter’s log formatting to avoid highlighting testPath and tweaks the header output structure.
- Replaces prettyTestPath with raw relative paths
- Refactors the log line to append log.name separately with dim gray separators
- Adds a leading blank line before each log block
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| logger.log( | ||
| `${log.name}${color.gray(color.dim(` | ${titles.join(color.gray(color.dim(' | ')))}`))}`, | ||
| ); |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The nested color formatting here is hard to read and double-styles both the separators and the entire suffix, which is redundant. Consider simplifying by computing the separator once and/or only wrapping the final suffix, e.g., precompute sep and tail to avoid nested color.gray(color.dim(...)) calls.
| logger.log( | |
| `${log.name}${color.gray(color.dim(` | ${titles.join(color.gray(color.dim(' | ')))}`))}`, | |
| ); | |
| const sep = ' | '; | |
| const styledSep = color.gray(color.dim(sep)); | |
| const joinedTitles = titles.join(styledSep); | |
| const suffix = color.gray(color.dim(`${sep}${joinedTitles}`)); | |
| logger.log(`${log.name}${suffix}`); |
| titles.push(testPath); | ||
| } | ||
|
|
||
| logger.log(''); |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This adds a leading blank line before every log block, changing output spacing (previously there was only a trailing blank line). If the extra spacing wasn’t intended, consider removing this line or gating it (e.g., only when not the first log) to avoid double-blank-lines between entries.
Summary
update log display: not highlight testPath
before:

after:

Related Links
Checklist