Skip to content

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Oct 20, 2025

Summary

update log display: not highlight testPath

before:
img_v3_02r8_c177f823-b3bf-4018-b4ee-fb53f10b551g

after:
image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 20, 2025 11:56
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 673cef5
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/68f6237a0588680008a19a89
😎 Deploy Preview https://deploy-preview-630--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the reporter’s log formatting to avoid highlighting testPath and tweaks the header output structure.

  • Replaces prettyTestPath with raw relative paths
  • Refactors the log line to append log.name separately with dim gray separators
  • Adds a leading blank line before each log block

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +94 to +96
logger.log(
`${log.name}${color.gray(color.dim(` | ${titles.join(color.gray(color.dim(' | ')))}`))}`,
);
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The nested color formatting here is hard to read and double-styles both the separators and the entire suffix, which is redundant. Consider simplifying by computing the separator once and/or only wrapping the final suffix, e.g., precompute sep and tail to avoid nested color.gray(color.dim(...)) calls.

Suggested change
logger.log(
`${log.name}${color.gray(color.dim(` | ${titles.join(color.gray(color.dim(' | ')))}`))}`,
);
const sep = ' | ';
const styledSep = color.gray(color.dim(sep));
const joinedTitles = titles.join(styledSep);
const suffix = color.gray(color.dim(`${sep}${joinedTitles}`));
logger.log(`${log.name}${suffix}`);

Copilot uses AI. Check for mistakes.
titles.push(testPath);
}

logger.log('');
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This adds a leading blank line before every log block, changing output spacing (previously there was only a trailing blank line). If the extra spacing wasn’t intended, consider removing this line or gating it (e.g., only when not the first log) to avoid double-blank-lines between entries.

Copilot uses AI. Check for mistakes.
@9aoy 9aoy merged commit 68dae3c into main Oct 21, 2025
20 checks passed
@9aoy 9aoy deleted the log-ui branch October 21, 2025 05:29
@9aoy 9aoy mentioned this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants