fix: use project root's absolute path #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CI issue in Rspack by ensuring project root paths are converted to absolute paths before processing. The change addresses a bug where relative paths in project configurations were not being resolved correctly, causing test failures in the CI environment.
- Normalizes project root paths to absolute paths using
getAbsolutePath()helper - Updates test expectations to use relative paths, allowing the normalization logic to handle conversion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/core/rstest.ts | Adds normalization of project root paths to absolute paths before config processing |
| packages/core/tests/core/rstest.test.ts | Updates test to use relative path, expecting the normalization to convert it to absolute |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chenjiahan
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix rspack ci, use project root's absolute path.
Related Links
https://github.com/web-infra-dev/rspack/actions/runs/18646266154/job/53154423141#step:8:1354
Checklist