feat: support show summary status when test running #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a running summary to the status output so users can see aggregate progress (files and duration) while tests execute.
- Emit onTestFileStart from the worker (before loading), remove the runner hook and propagate results directly to the status renderer.
- Extend StatusRenderer to track finished modules, render a summarized “Test Files” line and elapsed “Duration,” and update reporters to use onTestFileResult.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/runner.ts | Removes onTestFileStart from RunnerHooks, narrowing the runner hook surface. |
| packages/core/src/runtime/worker/index.ts | Emits onTestFileStart via RPC before loading files; removes hook plumbing to runner. |
| packages/core/src/runtime/runner/runner.ts | Drops internal onTestFileStart hook invocation. |
| packages/core/src/reporter/verbose.ts | Uses statusRenderer.onTestFileResult to update status. |
| packages/core/src/reporter/index.ts | Uses statusRenderer.onTestFileResult to update status. |
| packages/core/src/reporter/statusRenderer.ts | Implements summary rendering (running modules, test file counts, duration) and tracks finished tests. |
Comments suppressed due to low confidence (1)
packages/core/src/reporter/statusRenderer.ts:1
- [nitpick] The repeated magic number 11 in padStart makes alignment assumptions implicit. Consider extracting a constant (e.g., const LABEL_WIDTH = 11) to clarify intent and avoid scattered literals.
import { relative } from 'pathe';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| if (this.testModules.length === 0) { | ||
| summary.push( | ||
| `${color.gray('Test Files'.padStart(11))} ${this.runningModules.size} total`, |
There was a problem hiding this comment.
[nitpick] The repeated magic number 11 in padStart makes alignment assumptions implicit. Consider extracting a constant (e.g., const LABEL_WIDTH = 11) to clarify intent and avoid scattered literals.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
support show summary status when test running
Related Links
Checklist