revert: fix: align amd option behavior with webpack#9103
Merged
Conversation
github-actions
Bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
ahabhgk
changed the title
amd option behavior with webpack
CodSpeed Performance ReportMerging #9103 will not alter performanceComparing Summary
|
hardfist
approved these changes
Jan 23, 2025
Contributor
|
Revert this commit is indeed a bad decision, so can I safely set amd to |
Contributor
Author
|
Back then this feature has bugs, so I think it's fairly reasonable to revert this commit, now this feature is stabled in >=v1.3.0-beta.0 and we've updated our docs and added the reason about why we decided to keep the defaults as is https://rspack.dev/config/other-options#amd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revert #9011
In #9011 we have basic AMD support, but there are still some edge cases that will broken by AMD, so we disable it for now, we will re-enable it when our AMD support becomes more stable
Checklist