feat: add chunkGraph.getNumberOfEntryModules#9035
Merged
SyMind merged 3 commits intoweb-infra-dev:mainfrom Jan 21, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #9035 will not alter performanceComparing Summary
|
SyMind
approved these changes
Jan 21, 2025
2 tasks
github-merge-queue Bot
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Apr 2, 2025
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> This patch deletes the `ChunkLoadingRspackPlugin` and use `ChunkLoadingWebpackPlugin` directly in Rspack. We are doing it now since we have implemented all the APIs needed. - web-infra-dev/rspack#9035 - web-infra-dev/rspack#9092 - web-infra-dev/rspack#9093 > [!CAUTION] > This is a **BREAKING CHANGE** since you need to use `chunkLoading: 'lynx'` instead of `chunkLoading: 'require'`. fix: #253 since we do not relay on `hooks.runtimeModule` which could cause issue. <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the
chunkGraph.getNumberOfEntryModulesAPI of Webpack.See: https://github.com/webpack/webpack/blob/3919c844eca394d73ca930e4fc5506fb86e2b094/lib/ChunkGraph.js#L1187
This allows getting the number of entry modules without iterating over it(which has better performance).
Checklist