Skip to content

fix: align amd option behavior with webpack#9011

Merged
ahabhgk merged 9 commits intoweb-infra-dev:mainfrom
nilptr:nilptr/refactor/amd-doc
Jan 20, 2025
Merged

fix: align amd option behavior with webpack#9011
ahabhgk merged 9 commits intoweb-infra-dev:mainfrom
nilptr:nilptr/refactor/amd-doc

Conversation

@nilptr
Copy link
Copy Markdown
Contributor

@nilptr nilptr commented Jan 14, 2025 •
edited
Loading

Summary

closes #8987

  • fix: align amd option behavior with webpack
    amd plugins should be applied unless amd option is set to false
  • doc: add doc for amd option

other fixes:

  • fix: brackets are missing in the generated code for require(["deps"]) 4ec6bfc
  • define/define()/typeof define processing should be skipped if the module is esm 7954d46
  • add byDependency.amd to getResolveDefaults. Otherwise, amd define/require cannot resolve modules without extensions b61a6f1
  • update defaults tests snapshots 3eff58c
  • update webpack tests snapshots 7431665

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e93a722
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/678de50b5859ff0008627c1e
😎 Deploy Preview https://deploy-preview-9011--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nilptr
nilptr commented Jan 14, 2025
View reviewed changes
Comment thread packages/rspack/src/config/normalization.ts Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9011 will not alter performance

Comparing nilptr:nilptr/refactor/amd-doc (e93a722) with main (58a6af6)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@nilptr nilptr changed the title align amd option behavior with webpack and add doc for amd option fix: align amd option behavior with webpack Jan 15, 2025
@github-actions github-actions Bot added the release: bug fix release: bug related release(mr only) label Jan 15, 2025
@nilptr nilptr changed the title fix: align amd option behavior with webpack Draft: fix: align amd option behavior with webpack Jan 15, 2025
@github-actions github-actions Bot removed the release: bug fix release: bug related release(mr only) label Jan 15, 2025
@nilptr nilptr force-pushed the nilptr/refactor/amd-doc branch 2 times, most recently from 415b69c to a13a6da Compare January 16, 2025 15:45
@nilptr nilptr force-pushed the nilptr/refactor/amd-doc branch from a13a6da to c0460c7 Compare January 17, 2025 01:53
nilptr added 4 commits January 17, 2025 23:19
@nilptr
fix: align amd option behavior with webpack
bb0d34c
@nilptr
doc: add doc for amd option
82a862a
@nilptr
fix: esm-commonjs-mix test case
7954d46
@nilptr
chore(APIPlugin): require.amd is supported now
121c310 
chore(normal/parsing/unsupport-require-property): require.amd should not be undefined now
chore(normal/parsing/unsupport-require-property): require.version & require.onError to be discussed
@nilptr nilptr force-pushed the nilptr/refactor/amd-doc branch from c0460c7 to 7431665 Compare January 17, 2025 15:34
@nilptr nilptr changed the title Draft: fix: align amd option behavior with webpack fix: align amd option behavior with webpack Jan 19, 2025
ahabhgk
ahabhgk reviewed Jan 20, 2025
View reviewed changes
Comment thread website/components/PluginSupportStatusTable.tsx
Comment thread website/components/PluginSupportStatusTable.tsx
@nilptr nilptr force-pushed the nilptr/refactor/amd-doc branch from c3ba48b to 7431665 Compare January 20, 2025 04:17
@nilptr nilptr force-pushed the nilptr/refactor/amd-doc branch from 7431665 to e93a722 Compare January 20, 2025 05:54
ahabhgk
ahabhgk approved these changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahabhgk ahabhgk merged commit 1c0a097 into web-infra-dev:main Jan 20, 2025
@nilptr nilptr mentioned this pull request Jan 22, 2025
Closed
@ahabhgk ahabhgk mentioned this pull request Jan 23, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tracking]: Lack of documentation for AMD configuration

2 participants

@nilptr @ahabhgk