Skip to content

feat(rspack_cacheable): as attr support use with dyn trait#8535

Merged
jerrykingxyz merged 2 commits intomainfrom
jerry/cacheable
Nov 26, 2024
Merged

feat(rspack_cacheable): as attr support use with dyn trait#8535
jerrykingxyz merged 2 commits intomainfrom
jerry/cacheable

Conversation

@jerrykingxyz
Copy link
Copy Markdown
Contributor

@jerrykingxyz jerrykingxyz commented Nov 26, 2024

Summary

  1. Add ?Size for all of Serializer and Deserializer in rspack_cacheable
  2. as attr support use with dyn Trait

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions Bot added the release: feature release: feature related release(mr only) label Nov 26, 2024
@github-actions github-actions Bot added the team The issue/pr is created by the member of Rspack. label Nov 26, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 26, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7dcc40a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67458dc3166bd500086e7698

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #8535 will not alter performance

Comparing jerry/cacheable (7dcc40a) with main (27e8d88)

Summary

✅ 1 untouched benchmarks

@jerrykingxyz jerrykingxyz merged commit c1e8f11 into main Nov 26, 2024
@jerrykingxyz jerrykingxyz deleted the jerry/cacheable branch November 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants