feat(core): improve progress plugin for multi compiler#8301
Merged
chenjiahan merged 4 commits intomainfrom Oct 31, 2024
Merged
Conversation
github-actions
bot
added
release: feature
✅ Deploy Preview for rspack canceled.
|
LingyuCoder
previously approved these changes
Oct 31, 2024
h-a-n-a
previously approved these changes
Oct 31, 2024
h-a-n-a
approved these changes
Oct 31, 2024
chenjiahan
approved these changes
Oct 31, 2024
|
Thanks, it's mostly fixed :) Just one little remaining issue we have when we run another service worker later in the process: the previously compiled app will keep printing their progress bar. In this screenshot, the red bar should be alone:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #4214 improve progress plugin support for multi config
before
after
Checklist