Repository navigation
fix(worker): handle SharedWorker string name option - #15012
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 967ce20ed0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📦 Binary Size-limit
🙈 Size remains the same at 66.77MB |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
Fix the string name overload of
SharedWorker.Previously, Rspack transformed:
into:
This converted the string into an object without a
nameproperty, causing the SharedWorker name to be lost.This PR handles the second argument based on its syntax:
Object.assignbehavior.{ name: "chat", type: "module" }for module output.The new behavior is limited to
SharedWorker.Worker, Service Worker, Node.js Worker, and custom worker aliases are unchanged.Related links
Checklist