fix(rstest): apply globals option consistently to all rstest methods#12909
Closed
Copilot wants to merge 2 commits intorstest-importActualfrom
Closed
fix(rstest): apply globals option consistently to all rstest methods#12909Copilot wants to merge 2 commits intorstest-importActualfrom
Copilot wants to merge 2 commits intorstest-importActualfrom
Conversation
2 tasks
Co-authored-by: 9aoy <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address feedback on rstest.importActual functionality
fix(rstest): apply globals option consistently to all rstest methods
Feb 2, 2026
Contributor
Rsdoctor Bundle Diff Analysis
Found 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
🎉 Size decreased by 896bytes from 48.31MB to 48.31MB (⬇️0.00%) |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
globalsoption only gatedimportActual/requireActualincall_member_chain. Other methods (mock,doMock,importMock, etc.) inhandle_rstest_method_callignored this option, causing inconsistent behavior whereglobals: falsewould still transform globalrs/rstestusage.Changes
handle_rstest_method_callusingparser.is_variable_defined()globals: falsemock,mockRequire,doMock,doMockRequire,importMock,requireMock,unmock,doUnmock,resetModules,hoistedBehavior
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.