Skip to content

fix: unsafe cache cannot watch symlink#12891

Merged
SyMind merged 1 commit intov1.xfrom
fix-unsafe-cache-for-persisent-cache-v1
Jan 29, 2026
Merged

fix: unsafe cache cannot watch symlink#12891
SyMind merged 1 commit intov1.xfrom
fix-unsafe-cache-for-persisent-cache-v1

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Jan 29, 2026

Summary

This PR addresses issues with watching symlinked node_modules when using unsafe/persistent cache and ensures the module graph records correct file dependencies so changes are detected.

Relative #12885

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 29, 2026 11:41
@SyMind SyMind changed the base branch from main to v1.x January 29, 2026 11:41
@SyMind SyMind force-pushed the fix-unsafe-cache-for-persisent-cache-v1 branch from 19d0dfc to c1fe477 Compare January 29, 2026 11:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-5k 2.7 MB -
rome 984.2 KB -
ui-components 2.1 MB -
react-1k 825.4 KB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.4 KB - -
📄 JavaScript 825.4 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2026

📦 Binary Size-limit

Comparing c1fe477 to fix: should render export name when re-export from different modules (#12886) by Fy

🎉 Size decreased by 308.50KB from 48.32MB to 48.02MB (⬇️0.62%)

Copilot AI reviewed Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 29, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing fix-unsafe-cache-for-persisent-cache-v1 (c1fe477) with main (2fadd3a)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

  2. No successful run was found on v1.x (bbb60b7) during the generation of this report, so main (2fadd3a) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@SyMind SyMind merged commit 1cb57fa into v1.x Jan 29, 2026
74 of 76 checks passed
@SyMind SyMind deleted the fix-unsafe-cache-for-persisent-cache-v1 branch January 29, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder LingyuCoder is a code owner

@hardfist hardfist Awaiting requested review from hardfist

@chenjiahan chenjiahan Awaiting requested review from chenjiahan

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@stormslowly stormslowly Awaiting requested review from stormslowly

@quininer quininer Awaiting requested review from quininer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SyMind @jerrykingxyz