Skip to content

chore: enable backtrace for release-debug#12868

Merged
hardfist merged 1 commit intov1.xfrom
yj/enable-debug-trace
Jan 27, 2026
Merged

chore: enable backtrace for release-debug#12868
hardfist merged 1 commit intov1.xfrom
yj/enable-debug-trace

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Jan 27, 2026 •
edited
Loading

Summary

#12854 support backtrace but backtrace is empty becase build_std remove unwind-table info

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 27, 2026 12:00
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 27, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Jan 27, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: b750542
Status: ✅  Deploy successful!
Preview URL: https://b759933a.rspack-v2.pages.dev
Branch Preview URL: https://yj-enable-debug-trace.rspack-v2.pages.dev

View logs

Copilot AI reviewed Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the build configuration to enable backtrace functionality for the release-debug profile by removing it from the condition that determines when to use Rust's -Zbuild-std=panic_abort,std flag.

Changes:

  • Removes release-debug profile from the use_build_std condition in the build script, allowing backtraces to work properly for this profile while maintaining optimization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2026

📦 Binary Size-limit

Comparing b750542 to fix(mf): respect request changes in shared plugins (#12863) by Gengkun

🎉 Size decreased by 331.50KB from 48.34MB to 48.02MB (⬇️0.67%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 27, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing yj/enable-debug-trace (b750542) with main (7445ef1)1

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark2

Footnotes

  1. No successful run was found on v1.x (43044a8) during the generation of this report, so main (7445ef1) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@hardfist hardfist merged commit 6aa3e5c into v1.x Jan 27, 2026
58 of 61 checks passed
@hardfist hardfist deleted the yj/enable-debug-trace branch January 27, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@quininer quininer quininer approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @quininer