chore: gracefully explain unsupported interfaces#12782
Merged
hardfist merged 3 commits intoweb-infra-dev:mainfrom Feb 3, 2026
Merged
chore: gracefully explain unsupported interfaces#12782hardfist merged 3 commits intoweb-infra-dev:mainfrom
hardfist merged 3 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging this PR will improve performance by 12.89%Comparing Summary
Performance Changes
Footnotes
|
ahabhgk
reviewed
Jan 20, 2026
Contributor
ahabhgk
left a comment
ahabhgk
left a comment
There was a problem hiding this comment.
LGTM, need a test case to avoid regression
hardfist
requested review from
LingyuCoder,
chenjiahan,
h-a-n-a,
jerrykingxyz,
quininer and
stormslowly
as code owners
When webpack plugins try to access hooks that don't exist in rspack, provide a clear error message instead of the cryptic "Cannot read properties of undefined (reading 'tap')". The error message explains: - Which hook is not supported - That this typically happens with webpack plugins - Lists all available hooks for reference This helps developers quickly identify webpack compatibility issues.
martinjlowm
force-pushed
the
claude/fix-rspack-plugin-error-fPBUp
branch
from
fc16388 to
c75e1ce
Compare
hardfist
previously approved these changes
Jan 25, 2026
hardfist
approved these changes
Feb 3, 2026
Contributor
|
@martinjlowm Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Webpack plugins try to access hooks that don't exist in rspack, provide a clear error message instead of a cryptic message, e.g. "Cannot read properties of undefined (reading 'tap')" (attempting to use
pino-webpack-pluginwith rspack).The error message explains:
This helps developers quickly identify webpack compatibility issues.
While I haven't tested it, this should hopefully catch #12617 as well way before the panic.
Checklist