fix: track package.json files in node_modules as build dependencies #12274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds tracking of package.json files in node_modules as build dependencies to ensure proper cache invalidation when package metadata changes. This is important for build correctness as changes to package.json files (such as version updates or exports field modifications) can affect module resolution and should trigger cache invalidation.
Key changes:
- Modified build dependency tracking to include
package.jsonfiles for resolved modules innode_modules - Refactored
is_node_package_pathutility function frombuild_dependencies/utils.rstobuild_dependencies/helper/utils.rs - Extended test coverage to verify cache invalidation behavior for both library and project
package.jsonchanges
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_core/src/cache/persistent/build_dependencies/mod.rs |
Updated import to use is_node_package_path from helper module |
crates/rspack_core/src/cache/persistent/build_dependencies/helper/mod.rs |
Added logic to track package.json files for resolved modules in node_modules; added test case |
crates/rspack_core/src/cache/persistent/build_dependencies/helper/utils.rs |
Refactored utility function location; changed parameter type from &ArcPath to &Path |
tests/rspack-test/cacheCases/common/build-dependencies-resolve/rspack.config.js |
Extended test to cover package.json modification scenarios |
tests/rspack-test/cacheCases/common/build-dependencies-resolve/package.json |
Added project package.json test fixture |
tests/rspack-test/cacheCases/common/build-dependencies-resolve/other.config.js |
Added dependency and comments for clarity |
tests/rspack-test/cacheCases/common/build-dependencies-resolve/node_modules/lib/package.json |
Added version field for testing |
tests/rspack-test/cacheCases/common/build-dependencies-resolve/index.js |
Extended test assertions for new compilation runs |
tests/rspack-test/cacheCases/common/build-dependencies-resolve/file.js |
Added new test data versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 7.50KB from 47.63MB to 47.64MB (⬆️0.02%) |
CodSpeed Performance ReportMerging #12274 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When recursively resolve BuildDependencies, for performance reasons, resolver will stop when it reaches files within node_modules. This may cause problems when users upgrade dependencies, so package.json needs to be added to buildDependencies.
Related links
Checklist