fix(cli): devServer.hot: false not work
#12261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where setting devServer.hot: false in the configuration was ignored when using Rspack CLI. The fix ensures that the normalizeHotOption function properly respects the user's configuration instead of defaulting to true.
Key changes:
- Modified
normalizeHotOptionto return the value as-is if it's not a string, preventing unwanted defaults - Extracted default hot value to a constant (
DEFAULT_SERVER_HOT) for better maintainability - Added comprehensive test coverage for the disable HMR functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/rspack-cli/src/commands/serve.ts |
Fixed normalizeHotOption logic to properly handle false values; refactored code for better readability with renamed variables and removed empty lines |
packages/rspack-cli/src/constants.ts |
Added DEFAULT_SERVER_HOT constant to centralize the default hot value |
packages/rspack-cli/tests/serve/disable-hot/serve-flags.test.ts |
Added new test to verify that HMR can be disabled via devServer.hot: false |
packages/rspack-cli/tests/serve/disable-hot/rspack.config.js |
Configuration file for the disable-hot test case |
packages/rspack-cli/tests/serve/disable-hot/src/index.js |
Sample entry file for the disable-hot test case |
packages/rspack-cli/tests/serve/flags/serve-flags.test.ts |
Changed it.concurrent to test for consistency (note: should be reverted) |
packages/rspack-cli/tests/serve/flags/rspack.config.js |
Refactored onListening from function expression to method shorthand |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.63MB |
CodSpeed Performance ReportMerging #12261 will not alter performanceComparing Summary
|
stormslowly
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
devServer.hot: falsenot work when using Rspack CLI, thenormalizeHotOptionmethod should not return true by default.Related links
devServer.hot: falsedoesn't disable HMR #12258Checklist