Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • update dependency create-rstack to v1.7.8
  • replace hardcoded package manager commands with template variables in documentation files

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 20, 2025 05:42
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Nov 20, 2025
@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d419390
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/691eaa3bbe0dc70008a98d94

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the create-rstack dependency from version 1.7.7 to 1.7.8 and replaces hardcoded npm commands with {{ packageManager }} template variables in documentation files. This allows the generated project templates to use the appropriate package manager (npm, pnpm, yarn, etc.) based on what the user selected during project creation.

Key Changes:

  • Updated create-rstack dependency to version 1.7.8
  • Replaced hardcoded npm commands with dynamic {{ packageManager }} template variables in README.md and AGENTS.md

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pnpm-lock.yaml Updated lock file to reflect create-rstack version bump from 1.7.7 to 1.7.8
packages/create-rspack/package.json Updated create-rstack dependency from 1.7.7 to 1.7.8
packages/create-rspack/template-common/README.md Replaced hardcoded npm commands with {{ packageManager }} template variable for install, dev, build, and preview commands
packages/create-rspack/template-common/AGENTS.md Replaced hardcoded npm commands with {{ packageManager }} template variable for dev, build, and preview commands
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing d419390 to chore: disable Rslint warnings (#12243) by neverland

🙈 Size remains the same at 47.62MB

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #12248 will not alter performance

Comparing create_rspack_manager_1120 (d419390) with main (1f482b5)

Summary

✅ 17 untouched

@chenjiahan chenjiahan requested a review from 9aoy November 20, 2025 07:00
@chenjiahan chenjiahan merged commit 92f28c7 into main Nov 20, 2025
56 checks passed
@chenjiahan chenjiahan deleted the create_rspack_manager_1120 branch November 20, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants