test: maxConcurrency and testTimeout should be configurable via cli options
#12231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds CLI configurability for maxConcurrency and testTimeout test options. The maxConcurrency option can now be passed via --maxConcurrency CLI argument, and testTimeout is set to a fixed 300 seconds in the config.
- Added CLI argument parsing for
--maxConcurrencywhich setsDEFAULT_MAX_CONCURRENTenvironment variable - Modified
creator.tsto readDEFAULT_MAX_CONCURRENTfrom environment and use it as the default max concurrent value - Set
testTimeoutto 300000ms (5 minutes) in the test config, overriding the previous conditional timeout - Removed hardcoded timeout fallback (300000ms) in the test creator
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/rspack-test/rstest.config.ts | Added CLI argument parsing for --maxConcurrency and set fixed testTimeout to 300000ms |
| packages/rspack-test-tools/src/test/creator.ts | Updated DEFAULT_MAX_CONCURRENT to read from environment variable and removed hardcoded timeout fallback |
Comments suppressed due to low confidence (1)
tests/rspack-test/rstest.config.ts:40
- This property is overwritten by another property in the same object literal.
testTimeout: process.env.CI ? 60000 : 30000,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.48MB |
CodSpeed Performance ReportMerging #12231 will not alter performanceComparing Summary
Footnotes |
LingyuCoder
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test
maxConcurrencyandtestTimeoutconfigurations should be configurable via cli optionsRelated links
Checklist