Skip to content

Conversation

@h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Nov 14, 2025

Summary

Add multi-platform test for rspack_watcher

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 14, 2025 06:12
@h-a-n-a h-a-n-a requested a review from stormslowly as a code owner November 14, 2025 06:12
@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 85b378e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6916d8e2b2990200081105ad

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cross-platform CI testing for the native watcher component by introducing a new rust_watcher_test job that runs on Ubuntu, Windows, and macOS platforms.

Key Changes

  • Added a new rust_watcher_test job with a matrix strategy to test rspack_watcher across three operating systems
  • Configured platform-specific runners with appropriate fallbacks for self-hosted runners on Linux
  • Reused existing test setup patterns (Rust toolchain installation, profile configuration)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@h-a-n-a h-a-n-a enabled auto-merge (squash) November 14, 2025 06:29
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

📦 Binary Size-limit

Comparing 85b378e to fix: triple with windows-msvc doesn't support -Cforce-unwind-tables=no (#12196) by Fy

🙈 Size remains the same at 47.45MB

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #12197 will not alter performance

Comparing watcher-cross (85b378e) with main (7d4a1a3)

Summary

✅ 17 untouched

@h-a-n-a h-a-n-a merged commit a85877a into main Nov 14, 2025
47 checks passed
@h-a-n-a h-a-n-a deleted the watcher-cross branch November 14, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants