Skip to content

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Nov 13, 2025

Summary

Rename create-rspack-canary to create-rspack-debug for the release debug workflow to work successfully.

Both the release debug and the release canary workflows are verified.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 13, 2025 06:42
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 13, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit e52c63d
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69157df03a3d89000967dac4
😎 Deploy Preview https://deploy-preview-12182--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the debug package release workflow by making the package naming logic more flexible. Previously, create-rspack was hardcoded to be renamed as create-rspack-canary, which prevented the debug release workflow from functioning correctly.

  • Changed the getNextName function to use the scopePostfix parameter dynamically instead of hardcoding "canary"
  • Ensures consistency with the rest of the function, which already uses scopePostfix for other package names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing e52c63d to chore(ci): revert cache action version (#12170) by pshu

❌ Size increased by 128bytes from 48.10MB to 48.10MB (⬆️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #12182 will not alter performance

Comparing chore/fix_release_debug_failure (e52c63d) with main (1126c09)

Summary

✅ 17 untouched

@stormslowly stormslowly requested a review from hardfist November 13, 2025 07:06
@stormslowly stormslowly merged commit 12281db into main Nov 13, 2025
170 of 171 checks passed
@stormslowly stormslowly deleted the chore/fix_release_debug_failure branch November 13, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants