chore(ci): fix artifacts slow download #12171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.10MB |
CodSpeed Performance ReportMerging #12171 will not alter performanceComparing Summary
Footnotes |
stormslowly
force-pushed
the
chore/fix_artifacts
branch
from
6c5a4fc to
0534803
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the artifact upload/download GitHub Actions to improve performance for self-hosted runners by uploading artifacts to both local storage and GitHub storage, enabling fast local access while maintaining artifact transparency.
- Modified artifact upload action to always upload to GitHub (removing conditional) and reordered steps to upload to local storage first on self-hosted runners
- Updated artifact download action to simplify conditionals based only on runner environment type
- Updated commit hashes for lynx-infra custom actions with improved documentation links
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/actions/artifact/upload/action.yml | Reordered upload steps (local first, then GitHub) and removed conditional from GitHub upload to ensure all artifacts are uploaded to GitHub for transparency |
| .github/actions/artifact/download/action.yml | Simplified download conditionals to only check runner environment type, removing support for the force-use-github parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hardfist
approved these changes
Nov 13, 2025
hardfist
approved these changes
Nov 13, 2025
stormslowly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the slow downloading problem in the self-hosted runners.
solution
Upload artifacts to both self-hosted storage and GitHub storage.
And then download from the nearest storage. So we can benefit from both high net speed and artifact transparency.
After this PR, the duration of downloading the largest artifact will be restored to seconds from an hour.
Related links
Checklist