fix: keep entry chunk signature #12133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
JSerFeng
force-pushed
the
fix/prevent-entry-signiture
branch
from
79465c3 to
bf4e0b6
Compare
github-actions
bot
added
the
team
github-actions
bot
added
the
release: bug fix
Contributor
Author
Contributor
JSerFeng
force-pushed
the
fix/prevent-entry-signiture
branch
from
6d28905 to
c086536
Compare
quininer
reviewed
Nov 10, 2025
quininer
previously approved these changes
Nov 10, 2025
Contributor
📦 Binary Size-limit
❌ Size increased by 26.50KB from 47.93MB to 47.95MB (⬆️0.05%) |
CodSpeed Performance ReportMerging #12133 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Nov 10, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should always make sure entry chunk signature won't be ruined by other chunk imports.
When user use splitChunk to split module out from the entry chunk, there is a cycle and other chunks may import the symbol from the entry chunk. The entry chunk has to expose those symbols.
Check if other chunk has modules depends on modules inside entry chunk, if so, generate a chunk to avoid such things
Related links
Checklist