chore: remove webpackBootstrap comment from output #12108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the // webpackBootstrap comment from the generated JavaScript bundle output. The comment previously appeared in the IIFE wrapper at the top of bundled files and has been removed to reduce bundle size.
Key changes:
- Removed the
// webpackBootstrapcomment from the IIFE wrapper in both arrow function and regular function formats - Updated all snapshot tests to reflect the reduced bundle sizes (typically 20 bytes smaller)
- Updated test assertions that checked for the presence of this comment
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_plugin_javascript/src/plugin/mod.rs | Removed // webpackBootstrap comment from IIFE wrapper generation |
| tests/rspack-test/configCases/library/amd-named/index.js | Updated test assertion to match new output without the comment |
| tests/rspack-test/statsOutputCases/*/stats.txt | Updated snapshot files reflecting reduced bundle sizes |
| tests/rspack-test/hookCases/*/output.snap.txt | Updated hook test snapshots to match new output format |
| tests/rspack-test/hookCases/*/hooks.snap.txt | Updated hook snapshots showing asset content without the comment |
| tests/rspack-test/configCases/rsdoctor/assets/rspack.config.js | Updated inline snapshot with new asset sizes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.89MB |
CodSpeed Performance ReportMerging #12108 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the redundant
// webpackBootstrapcomment from Rspack's generated bundles to make the output cleaner.The comment originally came from webpack’s bundle template to mark the beginning of its runtime bootstrap code. However, it no longer serves any functional or semantic purpose — it's purely historical and has no effect on execution or debugging.
Related
Checklist