fix: render external re-exports #12089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances support for re-exporting from external modules in ESM library output by introducing more granular handling of different export patterns. Previously, only export * from external modules was optimized; now the plugin handles all re-export forms including named exports, default exports, and namespace exports from external modules.
Key Changes
- Modified the re-export data structure to support both chunk-based and request-based (external module) re-exports
- Added comprehensive handling for all
ExportModevariants when re-exporting from external modules - Enhanced the rendering logic to distinguish between chunk re-exports and external module re-exports
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_plugin_esm_library/src/chunk_link.rs | Introduced ReExportFrom enum to differentiate chunk vs. request-based re-exports; changed raw_star_exports from set to map to track export names |
| crates/rspack_plugin_esm_library/src/link.rs | Added re_export_from_external_module function to handle all external module re-export modes; added logic to skip external re-exports when collecting exports |
| crates/rspack_plugin_esm_library/src/render.rs | Updated rendering logic to handle both star exports with names and re-exports from external modules vs. chunks |
| tests/rspack-test/esmOutputCases/re-exports/*/*.snap.txt | Updated test snapshots to reflect new external module re-export output format |
| tests/rspack-test/esmOutputCases/re-exports/re-export-namespaced-external/*.js | Added new test case for external module re-exports with various export patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 11.13KB from 47.85MB to 47.86MB (⬆️0.02%) |
JSerFeng
force-pushed
the
fix/reexport-external
branch
3 times, most recently
from
179cd7f to
08ea7b8
Compare
CodSpeed Performance ReportMerging #12089 will not alter performanceComparing Summary
|
JSerFeng
force-pushed
the
fix/reexport-external
branch
from
a7ca36e to
32ac475
Compare
ahabhgk
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Special handle for re-export from external module. Should render re-exports for all ExportMode
Related links
Checklist