fix(config): validate output.path must be absolute
#12061
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to ensure output.path is an absolute path and updates documentation to reflect this requirement. However, there's a critical conflict between the validation code and the template changes.
- Adds
validateOutputPathfunction to enforce absolute path requirement foroutput.path - Updates English and Chinese documentation to clarify path requirements
- Modifies React JS template configuration (introducing a conflict)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/rspack/src/util/validateConfig.ts | Adds validation function to check that output.path is an absolute path |
| website/docs/en/config/output.mdx | Updates documentation to list path requirements as bullet points including absolute path requirement |
| website/docs/zh/config/output.mdx | Chinese translation of documentation updates |
| packages/create-rspack/template-react-js/rspack.config.mjs | Adds output.path configuration with relative path (conflicts with validation) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.85MB |
CodSpeed Performance ReportMerging #12061 will not alter performanceComparing Summary
|
stormslowly
previously approved these changes
Nov 2, 2025
stormslowly
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
output.pathis an absolute path.Before
After
webpack
Checklist