feat: EsmLibraryPlugin can override invalid user config #12028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: feature
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the EsmLibraryPlugin to automatically apply required configuration options instead of requiring users to manually configure them. The plugin now sets necessary options like chunkFormat, concatenateModules, and chunkLoading internally, removing the burden from users.
- Moved configuration logic from user responsibility to automatic plugin setup via new
applyLimitsfunction - Enhanced split chunks configuration with additional settings for better ESM library output
- Added empty source check in Rust render code to avoid generating unnecessary wrapper code
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/plugins/rspack/esm-library-plugin.mdx | Removed manual configuration requirements from Chinese documentation |
| website/docs/en/plugins/rspack/esm-library-plugin.mdx | Removed manual configuration requirements from English documentation |
| packages/rspack/src/builtin-plugin/EsmLibraryPlugin.ts | Added applyLimits function to automatically configure required options and enhanced split chunks settings |
| packages/rspack-test-tools/src/case/esm-output.ts | Removed manual configuration from test defaults since plugin now handles it |
| crates/rspack_plugin_esm_library/src/render.rs | Added check to skip rendering empty module declarations |
Comments suppressed due to low confidence (1)
packages/rspack/src/builtin-plugin/EsmLibraryPlugin.ts:67
- The
checkConfigvalidation is now redundant and will always fail. SinceapplyLimitsis called on line 59 and setsconcatenateModulestofalse(line 10) andchunkFormattofalse(line 13), the subsequentcheckConfigcall on line 63 will check these same values that were just set. This validation should either be removed or moved beforeapplyLimitsis called to validate user-provided configuration before automatic correction.
let err;
if ((err = checkConfig(compiler.options))) {
throw new rspack.WebpackError(
`Conflicted config for ${EsmLibraryPlugin.PLUGIN_NAME}: ${err}`
);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 384bytes from 47.81MB to 47.81MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12028 will not alter performanceComparing Summary
Footnotes |
JSerFeng
force-pushed
the
esm-lib-plugin
branch
2 times, most recently
from
9516982 to
f4e4cb0
Compare
JSerFeng
force-pushed
the
esm-lib-plugin
branch
from
f4e4cb0 to
7953269
Compare
Timeless0911
temporarily deployed
to
npm-canary
GitHub Actions
Inactive
Timeless0911
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EsmLibraryPlugin will override user's invalid config
Related links
Checklist