fix: incremental wrong provided exports results caused panic when delete module #12009
Conversation
github-actions
bot
added
team
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic that occurs when deleting a module during incremental compilation with provided exports enabled. The issue was that when a module is deleted and its incoming dependencies are revoked, the parent modules of those dependencies weren't being marked as updated in the incremental system, causing inconsistent state.
Key Changes:
- Enabled the
providedExportsincremental feature in test configuration (previously disabled) - Added logic to track and mark parent modules of updated dependencies as modified during incremental compilation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/cases/incremental/remove-optimized-module/rspack.config.js | Re-enabled providedExports in incremental configuration to test the fix |
| crates/rspack_core/src/compiler/compilation.rs | Added tracking of parent modules for updated dependencies to ensure they're marked as modified in incremental mutations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Binary Size-limit
❌ Size increased by 2.38KB from 47.85MB to 47.85MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12009 will not alter performanceComparing Summary
|
Summary
Follow up for #11939
Related links
Checklist