fix(types): add createReadStream to OutputFileSystem interface #11963
+76
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the createReadStream method to the OutputFileSystem interface to align with webpack's filesystem interface definition. The change introduces supporting type definitions for stream options and filesystem implementations required by the createReadStream method.
Key Changes:
- Added
createReadStreamoptional method toOutputFileSysteminterface - Introduced supporting type definitions (
StreamOptions,FSImplementation,CreateReadStreamFSImplementation,ReadStreamOptions,CreateReadStream)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/rspack/src/util/fs.ts | Added type definitions for stream options and filesystem implementations, plus the createReadStream method to OutputFileSystem |
| packages/rspack/etc/core.api.md | API documentation update reflecting the new public types and interface changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.80MB |
CodSpeed Performance ReportMerging #11963 will not alter performanceComparing Summary
|
9aoy
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
createReadStreammethod to OutputFileSystem interface, align with webpack: https://github.com/webpack/webpack/blob/v5.102.1/types.d.ts#L12923-L12939Checklist