refactor(watcher): split watcher from rspack_fs
#11948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the watcher functionality from the rspack_fs crate into a new standalone rspack_watcher crate. This refactoring improves modularity by separating file system watching concerns from general file system operations.
Key Changes:
- Created new
rspack_watchercrate with its own Cargo.toml configuration - Updated import paths across multiple files to reference
rspack_watcherinstead ofrspack_fs::watcher - Removed watcher-related exports and dependencies from
rspack_fs
Reviewed Changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_watcher/Cargo.toml | Defines the new rspack_watcher crate with required dependencies including notify, tokio, and rspack utilities |
| crates/rspack_watcher/src/*.rs | Updates import paths to use crate-relative paths instead of watcher:: module paths |
| crates/rspack_fs/src/lib.rs | Removes watcher-related exports that have been moved to the new crate |
| crates/rspack_fs/Cargo.toml | Removes notify dependency no longer needed after watcher extraction |
| crates/rspack_binding_api/src/native_watcher.rs | Updates imports to use rspack_watcher instead of rspack_fs for watcher functionality |
| crates/rspack_binding_api/Cargo.toml | Adds rspack_watcher dependency |
| Cargo.toml | Registers the new rspack_watcher workspace member |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
the
team
Contributor
📦 Binary Size-limit
🎉 Size decreased by 128bytes from 47.80MB to 47.80MB (⬇️0.00%) |
GiveMe-A-Name
approved these changes
Oct 21, 2025
CodSpeed Performance ReportMerging #11948 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split watcher from
rspack_fsto a standalone craterspack_watcher.Related links
Checklist