perf(cli): simplify ESM file detection #11946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
chenjiahan
changed the title
github-actions
bot
added
release: performance
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies ESM file detection in rspack-cli by removing unnecessary path.extname() calls and refactoring the isEsmFile function. The optimization directly tests file paths against regex patterns instead of first extracting the extension, improving performance while maintaining the same functionality.
Key changes:
- Refactored
isEsmFileto test full file paths directly instead of extracting extensions first - Removed unnecessary
cwdparameter fromisEsmFileandcrossImportfunctions - Changed
isEsmFilefrom default export to named export
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/rspack-cli/src/utils/isEsmFile.ts | Simplified ESM detection by testing full paths and removed unused cwd parameter |
| packages/rspack-cli/src/utils/crossImport.ts | Updated to use named import and removed cwd parameter |
| packages/rspack-cli/src/utils/loadConfig.ts | Updated import statement and removed cwd arguments from crossImport calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.82MB |
CodSpeed Performance ReportMerging #11946 will not alter performanceComparing Summary
|
9aoy
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unnecessary
path.extname(filePath)call to improve performance slightly.Checklist