fix: esm output chunk module missing load dependent chunks #11945
+126
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ESM output chunk module dependency loading by ensuring that dependent chunks are properly loaded during entry startup. This aligns the behavior with webpack's implementation (PR #19619) and addresses a false-passing test case.
Key Changes
- Added startup rendering hook to handle dependent chunk loading
- Implemented import statement generation for dependent chunks in ESM format
- Added logic to install dependent chunks using runtime globals during startup
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 5.88KB from 47.82MB to 47.83MB (⬆️0.01%) |
CodSpeed Performance ReportMerging #11945 will not alter performanceComparing Summary
|
JSerFeng
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Align with webpack/webpack#19619, adding dependent chunks loading in the entry's startup.
The former test case
configCases/module/split-chunks-without-externals/index.jsis a false passing.So an E2E case is added to ensure the functionality.
Related links
Checklist