perf: move crypto imports to lazy require calls #11930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves startup performance by moving Node.js crypto module imports from top-level imports to lazy require calls within functions, deferring module loading until the crypto functionality is actually needed.
Key changes:
- Removed top-level crypto imports in favor of function-scoped require calls
- Applied this optimization to both hash creation utilities and subresource integrity functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rspack/src/util/createHash.ts | Replaced top-level crypto import with lazy requires in hash creation functions |
| packages/rspack/src/builtin-plugin/SubresourceIntegrityPlugin.ts | Moved crypto import from module level to function scope in computeIntegrity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
team
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.73MB |
CodSpeed Performance ReportMerging #11930 will not alter performanceComparing Summary
|
stormslowly
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move crypto imports from top-level to lazy require calls within functions to improve start up performance by deferring module loading until needed.
Checklist