perf: replace node:assert with explicit error checks #11928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes node:assert usage across the codebase and replaces assertions with explicit runtime checks that throw descriptive errors.
- Replace assert(...) with explicit if checks and throw new Error(...) in multiple modules
- Remove assert imports and (in one case) reposition a constant declaration after imports
- Minor string/grammar tweaks in error messages
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/src/util/fs.ts | Replaces an assertion in rmrf with a runtime type check; adjusts iteration over directory entries. |
| packages/rspack/src/rspackOptionsApply.ts | Replaces assertions with explicit checks for required options; updates error messages. |
| packages/rspack/src/rspack.ts | Adds explicit check for options.context and throws a descriptive error. |
| packages/rspack/src/loader-runner/index.ts | Removes assert and enforces invariants in setters; moves LOADER_PROCESS_NAME after imports. |
| packages/rspack/src/lib/EntryOptionPlugin.ts | Replaces assertion with explicit error for desc.import presence. |
| packages/rspack/src/config/defaults.ts | Replaces assertion with explicit error for non-nil target. |
| packages/rspack/src/config/adapter.ts | Replaces assertions with explicit errors for tsConfig type and module.defaultRules presence; validates node options. |
| packages/rspack/src/builtin-plugin/SplitChunksPlugin.ts | Replaces assertion with explicit error when rawOptions is undefined. |
| packages/rspack/src/Watching.ts | Replaces assertion with explicit error when compilation is missing. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.73MB |
CodSpeed Performance ReportMerging #11928 will not alter performanceComparing Summary
|
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
stormslowly
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
node:assertand replace all assertions with explicit error checks that throw descriptive errors.Checklist