ci: fix lazy-compilation/persistent-cache ci failed #11926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CI failure in the lazy-compilation/persistent-cache test by reordering test operations. The issue was that the page was being reloaded before the rspack server was rebooted, which could cause timing-related test failures.
Key changes:
- Moved the
await rspack.reboot()call to occur before assertions about the Component element - Removed the premature
await page.reload()call that occurred before the server reboot
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.67MB |
jerrykingxyz
force-pushed
the
jerry/ci
branch
from
bfd50bb to
009f91e
Compare
CodSpeed Performance ReportMerging #11926 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rspack.reboot() will automatically reload the page, remove page.reload() to avoid playwright errors.
Related links
Checklist