test: use jsdom runner to run all cases #11924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingyuCoder
requested review from
9aoy and
Copilot
and removed request for
Copilot
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates browser-oriented tests to run under a jsdom-driven WebRunner and removes the legacy FakeDocument path. It unifies the web runner, updates test utilities and configs, and adjusts tests to work with jsdom behavior.
- Replace FakeDocument and separate jsdom runner with a unified jsdom-based WebRunner
- Update TTestConfig and runner options (documentType removed; location introduced)
- Modernize tests to use getLinkSheet and jsdom-compatible assertions; adjust/skip a few cases
Reviewed Changes
Copilot reviewed 96 out of 111 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack-test-tools/src/runner/web/index.ts | Introduces unified jsdom WebRunner; resource loading, URL mapping, and helper utilities (getLinkSheet) |
| packages/rspack-test-tools/src/type.ts | Removes EDocumentType; TTestConfig now supports location |
| packages/rspack-test-tools/src/case/{runner,watch,hot,incremental}.ts | Switch runners/processors to jsdom WebRunner and location-based config |
| packages/rspack-test-tools/src/case/config.ts | findBundle returns CSS path relative to output for jsdom linking |
| tests/rspack-test/configCases/**/* | Update tests for jsdom semantics (computed styles, link sheet reading); add a filter for a problematic case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/rspack-test/configCases/web/prefetch-preload-module-jsonp/test.filter.js
Outdated
Show resolved
Hide resolved
tests/rspack-test/configCases/web/prefetch-preload-module-jsonp/test.config.js
Outdated
Show resolved
Hide resolved
tests/rspack-test/configCases/web/prefetch-preload-module-jsonp/index.mjs
Outdated
Show resolved
Hide resolved
tests/rspack-test/configCases/css/url-and-asset-module-filename/index.js
Show resolved
Hide resolved
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.73MB |
LingyuCoder
force-pushed
the
test/jsdom-runner-2
branch
from
ccf71a5 to
5548999
Compare
CodSpeed Performance ReportMerging #11924 will not alter performanceComparing Summary
|
9aoy
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related links
Checklist