test: migrate config tests to rstest #11895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates configuration tests from Jest to rstest, introducing rstest as an alternative testing framework while maintaining Jest for other tests. The migration involves updating test file references from jest to rstest, adding rstest configuration, and adjusting test helper code to support both frameworks.
Key Changes
- Added rstest configuration file and package dependency to enable rstest-based testing
- Updated all test files to use
rstestAPI instead ofjestAPI (spyOn, fn, etc.) - Modified test infrastructure to support both Jest and rstest through conditional globals
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rspack-test/rstest.config.ts | New rstest configuration mirroring Jest setup |
| tests/rspack-test/package.json | Added rstest dependency and test script |
| tests/rspack-test/jest.config.js | Excluded Config.test.js from Jest execution |
| packages/rspack-test-tools/src/test/creator.ts | Updated to support both Jest and rstest globals |
| packages/rspack-test-tools/src/helper/setup-env.ts | Added rstest environment variable handling |
| Multiple test files | Replaced jest references with rstest |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...s/rspack-test/configCases/concatenate-modules/runtime-specific-external/should-concat/lib.js
Show resolved
Hide resolved
...pack-test/configCases/concatenate-modules/runtime-specific-external/should-concat/connect.js
Show resolved
Hide resolved
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.67MB |
CodSpeed Performance ReportMerging #11895 will not alter performanceComparing Summary
Footnotes |
LingyuCoder
approved these changes
Oct 17, 2025
LingyuCoder
pushed a commit
that referenced
this pull request
Oct 17, 2025
9aoy
added a commit
that referenced
this pull request
Oct 17, 2025
9aoy
added a commit
that referenced
this pull request
Oct 20, 2025
* Revert "test: Revert 'migrate config tests to rstest (#11895)' (#11902)" This reverts commit 1ff04bd. * test: throw stepSignal error * test: run afterExecute after check * chore: bump rstest --------- Co-authored-by: LingyuCoder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
migrate config tests from jest to rstest.
jest:
rstest:
Related links
Checklist